Bug 36626 – Add webkit-patch lkgr for finding last known good revision

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add webkit-patch lkgr for finding last known good revision

[Eric Seidel (no email)]

Created attachment 51689 [details]
Patch

[Adam Barth]

Comment on attachment 51689 [details]
Patch

That's surprisingly complicated, but it makes some amount of sense.

r- for no tests!  There are lots of fun cases to probe for here.

[Mark Rowe (bdash)]

I’d suggest giving it a name that isn’t so unnecessarily obscure.

[Eric Seidel (no email)]

Created attachment 51699 [details]
Patch

[Eric Seidel (no email)]

Changed the name to "last-green-revision".  Thank you for the feedback.

[Adam Barth]

Comment on attachment 51699 [details]
Patch

Much nicer.  Maybe you'll be seduced into writing more tests with these fixtures.

[WebKit Commit Bot]

Comment on attachment 51699 [details]
Patch

Rejecting patch 51699 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '51699', '--no-update']" exit_code: 1
Last 500 characters of output:
ne 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/commit.py", line 34, in run
    commit_message = self._tool.checkout().commit_message_for_this_commit()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 65, in commit_message_for_this_commit
    return CommitMessage("".join(changelog_messages).splitlines())
NameError: global name 'CommitMessage' is not defined

[Eric Seidel (no email)]

Comment on attachment 51699 [details]
Patch

I've restarted the commit-bot.  Sorry for the noise.

[Adam Barth]

Comment on attachment 51699 [details]
Patch

Clearing flags on attachment: 51699

Committed r56602: <http://trac.webkit.org/changeset/56602>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.