Bug 36626 - Add webkit-patch lkgr for finding last known good revision
Summary: Add webkit-patch lkgr for finding last known good revision
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 16:18 PDT by Eric Seidel (no email)
Modified: 2010-03-25 22:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2010-03-25 16:19 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (5.75 KB, patch)
2010-03-25 17:34 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-03-25 16:18:29 PDT 
Add webkit-patch lkgr for finding last known good revision
Comment 1 Eric Seidel (no email) 2010-03-25 16:19:54 PDT 
Created attachment 51689 [details]
Patch
Comment 2 Adam Barth 2010-03-25 16:31:57 PDT 
Comment on attachment 51689 [details]
Patch

That's surprisingly complicated, but it makes some amount of sense.

r- for no tests!  There are lots of fun cases to probe for here.
Comment 3 Mark Rowe (bdash) 2010-03-25 17:14:56 PDT 
I’d suggest giving it a name that isn’t so unnecessarily obscure.
Comment 4 Eric Seidel (no email) 2010-03-25 17:34:58 PDT 
Created attachment 51699 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-03-25 17:35:29 PDT 
Changed the name to "last-green-revision".  Thank you for the feedback.
Comment 6 Adam Barth 2010-03-25 17:37:11 PDT 
Comment on attachment 51699 [details]
Patch

Much nicer.  Maybe you'll be seduced into writing more tests with these fixtures.
Comment 7 WebKit Commit Bot 2010-03-25 20:39:55 PDT 
Comment on attachment 51699 [details]
Patch

Rejecting patch 51699 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '51699', '--no-update']" exit_code: 1
Last 500 characters of output:
ne 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/commit.py", line 34, in run
    commit_message = self._tool.checkout().commit_message_for_this_commit()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 65, in commit_message_for_this_commit
    return CommitMessage("".join(changelog_messages).splitlines())
NameError: global name 'CommitMessage' is not defined
Comment 8 Eric Seidel (no email) 2010-03-25 21:18:47 PDT 
Comment on attachment 51699 [details]
Patch

I've restarted the commit-bot.  Sorry for the noise.
Comment 9 Adam Barth 2010-03-25 22:43:04 PDT 
Comment on attachment 51699 [details]
Patch

Clearing flags on attachment: 51699

Committed r56602: <http://trac.webkit.org/changeset/56602>
Comment 10 Adam Barth 2010-03-25 22:43:10 PDT 
All reviewed patches have been landed.  Closing bug.