WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36619
new-run-webkit-tests should use a test_expectations file in addition to Skipped files so we can handle pixel failures
https://bugs.webkit.org/show_bug.cgi?id=36619
Summary
new-run-webkit-tests should use a test_expectations file in addition to Skipp...
Dirk Pranke
Reported
2010-03-25 14:31:43 PDT
Skipped files give us no way to track pixel failures separately from other types of failures. If we start using a test_expectations.txt file we can track these and get a clean test run both with and without pixel tests enabled.
Attachments
patch
(6.89 KB, patch)
2010-03-25 14:41 PDT
,
Dirk Pranke
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2010-03-25 14:41:05 PDT
Created
attachment 51677
[details]
patch
Eric Seidel (no email)
Comment 2
2010-03-25 14:42:29 PDT
Comment on
attachment 51677
[details]
patch Maybe that should go in mac-leopard? LGTM.
Dirk Pranke
Comment 3
2010-03-25 14:58:01 PDT
test_expectations files should generally be as portable as possible, because maintaining multiple versions is a hassle, and one hopes that most bugs are cross-platform/cross-version, rather than version-specific.
Dirk Pranke
Comment 4
2010-03-26 17:15:30 PDT
Committed
r56648
: <
http://trac.webkit.org/changeset/56648
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug