Bug 36613 – Web Inspector: Cover the Audits panel with tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Currently there are no tests for the Audits panel, which should be fixed.

[Alexander Pavlov (apavlov)]

Created attachment 51727 [details]
[PATCH] Test for the Audits panel + drive-by rule fix

[Pavel Feldman]

Comment on attachment 51727 [details]
[PATCH] Test for the Audits panel + drive-by rule fix

> +<!-- These scripts are needed to result in a violation of the max JS file count from the same domain -->

You should put artificial scripts into the resources folder for this test instead.
 
> +            frontend_assertEquals("'" + ruleResult.value + "' violation count", expectedData[ruleResult.value], ruleResult.violationCount);

You should push information back to the inspected page instead and dump it onto the screen. That way expectations would reflect what is happening in the test.

[Alexander Pavlov (apavlov)]

Created attachment 51739 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Created attachment 51754 [details]
[PATCH] Full results tree dump in the test

[Pavel Feldman]

Comment on attachment 51754 [details]
[PATCH] Full results tree dump in the test

Couple of nits you should fix prior to landing:
- WebInspector.displayNameForURL is now test-friendly, no need to work around it
- You should try adding line breaks into the results dump as I do it for styles and elements tree for example.

[Alexander Pavlov (apavlov)]

Created attachment 51912 [details]
[PATCH] Comments addressed, some changes for environment-independent testing

Apologies for another round, I spotted another host-dependent test result (resource coalescing audit which involved printing resource.domain), so had to add an interim method to change one in test.

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       WebCore/ChangeLog
        M       WebCore/English.lproj/localizedStrings.js
        M       WebCore/inspector/front-end/AuditResultView.js
        M       WebCore/inspector/front-end/AuditRules.js
        M       WebCore/inspector/front-end/AuditsPanel.js
        M       WebCore/inspector/front-end/inspector.js
Committed r56732