Bug 36607 - [Qt] Package build on Maemo 5 is broken
Summary: [Qt] Package build on Maemo 5 is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P1 Blocker
Assignee: Simon Hausmann
Keywords: Qt
: 36880 (view as bug list)
Depends on:
Blocks: 35784
  Show dependency treegraph
Reported: 2010-03-25 09:44 PDT by Simon Hausmann
Modified: 2010-03-31 11:10 PDT (History)
3 users (show)

See Also:

Patch (1.03 KB, patch)
2010-03-25 09:46 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2010-03-25 09:44:43 PDT
RenderThemeQt.cpp depends on themeQtNoListboxesUserAgentStyleSheet when compiling for maemo5.

The corresponding stylesheet is only embedded in WebCore.pri when the corresponding listbox feature is enabled:

    STYLESHEETS_EMBED += $$PWD/css/themeQtNoListboxes.css

For the packaging we need to generate all files. Therefore it's the easiest to always embed the stylesheet, but enable the #define for the feature only when compiling for Maemo5.

The error message when compiling the package on Maemo5 is:

platform/qt/RenderThemeQt.cpp:187: error: 'themeQtNoListboxesUserAgentStyleSheet' was not declared in this scope
Comment 1 Simon Hausmann 2010-03-25 09:46:17 PDT
Created attachment 51649 [details]
Comment 2 WebKit Commit Bot 2010-03-25 16:12:14 PDT
Comment on attachment 51649 [details]

Clearing flags on attachment: 51649

Committed r56576: <http://trac.webkit.org/changeset/56576>
Comment 3 WebKit Commit Bot 2010-03-25 16:12:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2010-03-26 03:47:45 PDT
Revision r56576 cherry-picked into qtwebkit-2.0 with commit d362c2e1c4559bf5ab4b4efaf3b8b09613f7c3fd
Comment 5 Luiz Agostini 2010-03-31 11:10:21 PDT
*** Bug 36880 has been marked as a duplicate of this bug. ***