WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
36607
[Qt] Package build on Maemo 5 is broken
https://bugs.webkit.org/show_bug.cgi?id=36607
Summary
[Qt] Package build on Maemo 5 is broken
Simon Hausmann
Reported
2010-03-25 09:44:43 PDT
RenderThemeQt.cpp depends on themeQtNoListboxesUserAgentStyleSheet when compiling for maemo5. The corresponding stylesheet is only embedded in WebCore.pri when the corresponding listbox feature is enabled: contains(DEFINES, ENABLE_NO_LISTBOX_RENDERING=1) { STYLESHEETS_EMBED += $$PWD/css/themeQtNoListboxes.css } For the packaging we need to generate all files. Therefore it's the easiest to always embed the stylesheet, but enable the #define for the feature only when compiling for Maemo5. The error message when compiling the package on Maemo5 is: platform/qt/RenderThemeQt.cpp:187: error: 'themeQtNoListboxesUserAgentStyleSheet' was not declared in this scope
Attachments
Patch
(1.03 KB, patch)
2010-03-25 09:46 PDT
,
Simon Hausmann
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Hausmann
Comment 1
2010-03-25 09:46:17 PDT
Created
attachment 51649
[details]
Patch
WebKit Commit Bot
Comment 2
2010-03-25 16:12:14 PDT
Comment on
attachment 51649
[details]
Patch Clearing flags on attachment: 51649 Committed
r56576
: <
http://trac.webkit.org/changeset/56576
>
WebKit Commit Bot
Comment 3
2010-03-25 16:12:19 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 4
2010-03-26 03:47:45 PDT
Revision
r56576
cherry-picked into qtwebkit-2.0 with commit d362c2e1c4559bf5ab4b4efaf3b8b09613f7c3fd
Luiz Agostini
Comment 5
2010-03-31 11:10:21 PDT
***
Bug 36880
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug