Bug 36602 - [chromium] linux: prefer the "hinting" fontconfig preference.
Summary: [chromium] linux: prefer the "hinting" fontconfig preference.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Adam Langley
Depends on:
Reported: 2010-03-25 07:56 PDT by Adam Langley
Modified: 2010-05-17 00:49 PDT (History)
3 users (show)

See Also:

patch (7.32 KB, patch)
2010-03-25 08:04 PDT, Adam Langley
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2010-03-25 07:56:26 PDT
fontconfig can give contradictory hinting information, setting "hinting" to zero and "hintstyle" to non-zero. In this case we should take the "hinting" preference.
Comment 1 Adam Langley 2010-03-25 08:04:14 PDT
Created attachment 51641 [details]
Comment 2 Evan Martin 2010-03-25 08:18:59 PDT
Comment 3 David Levin 2010-03-25 09:50:35 PDT
Comment on attachment 51641 [details]

> diff --git a/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp b/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp
> +    default:
> +        paint->setHinting((SkPaint::Hinting) m_style.hintStyle);

Please use C++ style casting like this: 
Comment 4 Eric Seidel (no email) 2010-03-29 11:40:06 PDT
Attachment 51641 [details] was posted by a committer and has review+, assigning to Adam Langley for commit.
Comment 5 Eric Seidel (no email) 2010-05-17 00:45:26 PDT
Unsure of the status of this patch.  It's been in pending-commit for over a month.  Updates?
Comment 6 Tony Chang 2010-05-17 00:49:06 PDT
(In reply to comment #5)
> Unsure of the status of this patch.  It's been in pending-commit for over a month.  Updates?

This was landed in http://trac.webkit.org/changeset/56800.