Bug 36597 - [v8] Add if ENABLE guard for Worker specific code.
Summary: [v8] Add if ENABLE guard for Worker specific code.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Ben Murdoch
Depends on:
Reported: 2010-03-25 07:17 PDT by Kristian Monsen
Modified: 2010-03-30 05:44 PDT (History)
3 users (show)

See Also:

Patch number 1 (1.38 KB, patch)
2010-03-25 07:27 PDT, Kristian Monsen
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Monsen 2010-03-25 07:17:06 PDT
Guarding the funtion in the head as well as the implementation so it will cause a compile error instead of linker error.
Comment 1 Kristian Monsen 2010-03-25 07:27:08 PDT
Created attachment 51639 [details]
Patch number 1
Comment 2 David Levin 2010-03-25 09:59:48 PDT
Comment on attachment 51639 [details]
Patch number 1

> Index: WebCore/ChangeLog
> +2010-03-25  Kristian Monsen  <kristianm@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Guarding the function in the header as well.

I'll r+ *but* before committing the patch this line should be changed to the (new) title of the bug (a WK committer can do this for you right before they commit the change and I think you have a few nearby).

The problem is that right now this line doesn't tell you anything. Ideally one should be able to read this and get a sense of what was addressed (so folks can decide to look at the details or not -- think of it like a good email subject).
Comment 3 Kristian Monsen 2010-03-25 10:02:15 PDT
OK, thanks for the comment. I will update this bug and improve for next patch.
Comment 4 Ben Murdoch 2010-03-30 05:41:49 PDT
Will update Changelog as per review comments and land.
Comment 5 Ben Murdoch 2010-03-30 05:44:47 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/V8DOMWrapper.h
Transmitting file data ..
Committed revision 56778.