Bug 36590 - [Qt] Build JavaScriptCore as a static library
Summary: [Qt] Build JavaScriptCore as a static library
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt
Depends on: 37701
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-03-25 03:49 PDT by Jocelyn Turcotte
Modified: 2010-04-16 00:46 PDT (History)
2 users (show)

See Also:


Attachments
Patch (19.38 KB, patch)
2010-03-25 03:52 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch v2 (19.00 KB, patch)
2010-03-25 04:16 PDT, Jocelyn Turcotte
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2010-03-25 03:49:15 PDT
Currently, JavaScriptCore is build by including JavaScriptCore.pri in WebCore.pro, jsc.pro and QtScript.pro.
This .pri file just add JavaScriptCore's cpp files to the SOURCES variable.

Building JavaScriptCore statically before would prevent recompiling JavaScriptCore's cpp files for each project and would allow its objects files to be compiled with different optimization flags.
Comment 1 Jocelyn Turcotte 2010-03-25 03:52:10 PDT
Created attachment 51620 [details]
Patch
Comment 2 Jocelyn Turcotte 2010-03-25 04:16:52 PDT
Created attachment 51627 [details]
Patch v2

Removes unrelated hunk.
Comment 3 Simon Hausmann 2010-03-26 08:51:31 PDT
Committed r56623: <http://trac.webkit.org/changeset/56623>
Comment 4 Simon Hausmann 2010-03-26 08:53:43 PDT
Revision r56623 cherry-picked into qtwebkit-2.0 with commit b9a9ed485914673c4801be819f8906e933666435
Comment 5 Ismail Donmez 2010-03-27 03:15:46 PDT
This breaks the WinCE build (reverting the commit fixes the build ), I get:

pcre_compile.cpp
c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h'
: No such file or directory
pcre_exec.cpp
c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h'
: No such file or directory
pcre_tables.cpp
c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h'
: No such file or directory
pcre_ucp_searchfuncs.cpp
c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h'
: No such file or directory
pcre_xclass.cpp
c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h'
: No such file or directory


Looks like JavaScriptCore/os-win32 is not being added to includepath.
Comment 6 Simon Hausmann 2010-03-29 03:31:51 PDT
(In reply to comment #5)
> This breaks the WinCE build (reverting the commit fixes the build ), I get:

Filed #36751
Comment 7 Simon Hausmann 2010-03-29 03:32:10 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > This breaks the WinCE build (reverting the commit fixes the build ), I get:
> 
> Filed #36751

Err

https://bugs.webkit.org/show_bug.cgi?id=36751