Bug 36587 - Web Inspector: Expect console object wrapping to fail.
Summary: Web Inspector: Expect console object wrapping to fail.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 02:49 PDT by Pavel Feldman
Modified: 2010-03-25 05:20 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed fix. (4.20 KB, patch)
2010-03-25 03:18 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-25 02:49:36 PDT
This can happen if page overrides some basic prototypes.
Comment 1 Pavel Feldman 2010-03-25 03:18:46 PDT
Created attachment 51615 [details]
[PATCH] Proposed fix.
Comment 2 Timothy Hatcher 2010-03-25 04:34:39 PDT
Comment on attachment 51615 [details]
[PATCH] Proposed fix.

> +    // FIXME(33716)

Please add a comment with the FIXME, not just the bug number.
Comment 3 Pavel Feldman 2010-03-25 05:20:04 PDT
Landed with comment addressed.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InjectedScript.cpp
	M	WebCore/inspector/front-end/InjectedScript.js
Committed r56532