WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36582
REGRESSION: webkit-patch land can't land "rubber-stamped" patches
https://bugs.webkit.org/show_bug.cgi?id=36582
Summary
REGRESSION: webkit-patch land can't land "rubber-stamped" patches
Eric Seidel (no email)
Reported
2010-03-25 00:07:29 PDT
REGRESSION: webkit-patch land can't land "rubber-stamped" patches I don't think land should be nearly so strict in the manual use case. It should probably just warn.
Attachments
Patch
(1.32 KB, patch)
2010-03-25 16:34 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-03-25 15:46:40 PDT
Fixed in
http://trac.webkit.org/changeset/56554
Eric Seidel (no email)
Comment 2
2010-03-25 15:54:46 PDT
Sigh. I don't think that we should be prescribing "rubber stamp". It's common for folks to use "rubber-stamped".
Adam Barth
Comment 3
2010-03-25 16:33:23 PDT
ok
Adam Barth
Comment 4
2010-03-25 16:34:24 PDT
Created
attachment 51690
[details]
Patch
Eric Seidel (no email)
Comment 5
2010-03-25 16:37:34 PDT
Comment on
attachment 51690
[details]
Patch I still think this is error prone. I'm also saddened by lack of testing on this step.
Adam Barth
Comment 6
2010-03-25 16:42:30 PDT
Comment on
attachment 51690
[details]
Patch Yeah. It's a bit of an experiment. We might need to try a different approach at some point.
WebKit Commit Bot
Comment 7
2010-03-25 19:21:15 PDT
Comment on
attachment 51690
[details]
Patch Clearing flags on attachment: 51690 Committed
r56589
: <
http://trac.webkit.org/changeset/56589
>
WebKit Commit Bot
Comment 8
2010-03-25 19:21:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug