Bug 36566 - Fix a couple of places where fill-mode needs adding to the list of shorthand properties
Summary: Fix a couple of places where fill-mode needs adding to the list of shorthand ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-24 17:31 PDT by Simon Fraser (smfr)
Modified: 2010-05-14 02:58 PDT (History)
1 user (show)

See Also:


Attachments
patch for shorthand (2.57 KB, patch)
2010-03-25 16:55 PDT, Dean Jackson
eric: review-
Details | Formatted Diff | Diff
updated patch with testcase (9.56 KB, patch)
2010-05-08 16:05 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-03-24 17:31:33 PDT
Need to add CSSPropertyWebkitAnimationFillMode in CSSMutableStyleDeclaration::getPropertyValue() and initShorthandMap()
Comment 1 Dean Jackson 2010-03-25 16:55:02 PDT
Created attachment 51692 [details]
patch for shorthand

Adds the longhand property into the places where the shorthand is configured.
Comment 2 Eric Seidel (no email) 2010-03-26 00:58:05 PDT
Comment on attachment 51692 [details]
patch for shorthand

We can make a CSS parsing test for this pretty easily no?  Just check what getComputedStyle returns after parsing the fill mode text, no?  Or just set cssText on some CSS value and see what actually gets set?
Comment 3 Dean Jackson 2010-05-08 16:04:55 PDT
> We can make a CSS parsing test for this pretty easily no? 
> Just check what getComputedStyle returns after parsing the fill mode text, no? 
> Or just set cssText on some CSS value and see what actually gets set?

That's not quite what this code does. It is only executed in two places:

1. When animating shorthand properties. Since fill-mode is an animation property itself we can't animate it, so this doesn't apply here.

2. In removeProperty(), when called on a shorthand. I've attached a test case for that.
Comment 4 Dean Jackson 2010-05-08 16:05:42 PDT
Created attachment 55487 [details]
updated patch with testcase
Comment 5 Dean Jackson 2010-05-14 02:58:35 PDT
Landed in 59111