Bug 36566 – Fix a couple of places where fill-mode needs adding to the list of shorthand properties

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

Need to add CSSPropertyWebkitAnimationFillMode in CSSMutableStyleDeclaration::getPropertyValue() and initShorthandMap()

[Dean Jackson]

Created attachment 51692 [details]
patch for shorthand

Adds the longhand property into the places where the shorthand is configured.

[Eric Seidel (no email)]

Comment on attachment 51692 [details]
patch for shorthand

We can make a CSS parsing test for this pretty easily no?  Just check what getComputedStyle returns after parsing the fill mode text, no?  Or just set cssText on some CSS value and see what actually gets set?

[Dean Jackson]

> We can make a CSS parsing test for this pretty easily no? 
> Just check what getComputedStyle returns after parsing the fill mode text, no? 
> Or just set cssText on some CSS value and see what actually gets set?

That's not quite what this code does. It is only executed in two places:

1. When animating shorthand properties. Since fill-mode is an animation property itself we can't animate it, so this doesn't apply here.

2. In removeProperty(), when called on a shorthand. I've attached a test case for that.

[Dean Jackson]

Created attachment 55487 [details]
updated patch with testcase

[Dean Jackson]

Landed in 59111