WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
36561
[Qt] Make QWebPage not depend on view() but use the client->ownerWidget() instead
https://bugs.webkit.org/show_bug.cgi?id=36561
Summary
[Qt] Make QWebPage not depend on view() but use the client->ownerWidget() ins...
Kenneth Rohde Christiansen
Reported
2010-03-24 15:16:30 PDT
Created
attachment 51558
[details]
Patch Make QWebPage not depend on view() but use the client->ownerWidget() instead. Also, handle the case where there is not page client.
Attachments
Patch
(7.27 KB, patch)
2010-03-24 15:16 PDT
,
Kenneth Rohde Christiansen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antonio Gomes
Comment 1
2010-03-24 15:37:49 PDT
style nit: + QStyle *style = d->client ? d->client->style() : qApp->style();
Eric Seidel (no email)
Comment 2
2010-03-25 00:47:54 PDT
Comment on
attachment 51558
[details]
Patch OK.
WebKit Commit Bot
Comment 3
2010-03-25 04:23:31 PDT
Comment on
attachment 51558
[details]
Patch Clearing flags on attachment: 51558 Committed
r56529
: <
http://trac.webkit.org/changeset/56529
>
WebKit Commit Bot
Comment 4
2010-03-25 04:23:36 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 5
2010-03-26 08:34:24 PDT
Revision
r56529
cherry-picked into qtwebkit-2.0 with commit af7794bb8c23783a5a1dd5e5aadab33125fe543b
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug