Bug 36555 - Make calls to m_keyframeAnimations.checkConsistency() debug-only
Summary: Make calls to m_keyframeAnimations.checkConsistency() debug-only
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Reported: 2010-03-24 14:04 PDT by Simon Fraser (smfr)
Modified: 2010-03-25 14:34 PDT (History)
3 users (show)

See Also:

Patch (6.67 KB, patch)
2010-03-25 12:14 PDT, Simon Fraser (smfr)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-03-24 14:04:52 PDT
Animation code has a bunch of calls to m_keyframeAnimations.checkConsistency() that are in release builds. These should be debug-only.
Comment 1 Simon Fraser (smfr) 2010-03-24 14:05:15 PDT
Or we should remove them.
Comment 2 Alexey Proskuryakov 2010-03-24 17:08:50 PDT
These are supposed to be no-ops in release builds. Are they not?

We don't usually add ifdef NDEBUG at each call site if function name clearly indicates that it's debug-only, and has such ifdefs inside.
Comment 3 Simon Fraser (smfr) 2010-03-25 12:14:43 PDT
Created attachment 51669 [details]
Comment 4 Simon Fraser (smfr) 2010-03-25 12:57:09 PDT
Comment on attachment 51669 [details]

Comment 5 Simon Fraser (smfr) 2010-03-25 12:58:09 PDT
Comment 6 Darin Adler 2010-03-25 13:59:26 PDT
The premise of this bug was wrong, I think. The code is already debug-only.
Comment 7 Simon Fraser (smfr) 2010-03-25 14:23:55 PDT
Reopening to revert the change.
Comment 8 Simon Fraser (smfr) 2010-03-25 14:34:53 PDT
Backed out in http://trac.webkit.org/changeset/56568.