Bug 36554 - Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
Summary: Web Inspector: reloading debug target window with cmd-R from inspector window...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-24 13:53 PDT by Mike Wilcox
Modified: 2010-03-25 09:10 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Prevent Beeping (1.14 KB, patch)
2010-03-24 21:35 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Prevent Beep only when handled (1.27 KB, patch)
2010-03-24 21:38 PDT, Joseph Pecoraro
pfeldman: review+
pfeldman: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wilcox 2010-03-24 13:53:16 PDT
- reload debug target window with cmd-R from inspector window

Or in other words:
You can't refresh the page with command-r if the console is it's own window and in focus.

I gave an enhanced severity on this, because I believe this is the solitary feature that keeps it from being as good as Firebug.
Comment 1 Joseph Pecoraro 2010-03-24 21:34:50 PDT
Pavel is right, this works for me in the WebKit nightly. Mike which version are you using? Try updating to the latest at:
http://build.webkit.org/

This does however give me an ugly beep on mac. It seems a lot of keyboard shortcuts do that on the mac. There should probably be a preventDefault() somewhere.
Comment 2 Joseph Pecoraro 2010-03-24 21:35:24 PDT
Created attachment 51591 [details]
[PATCH] Prevent Beeping

Like here.
Comment 3 Joseph Pecoraro 2010-03-24 21:38:04 PDT
Created attachment 51592 [details]
[PATCH] Prevent Beep only when handled

This is probably better!
Comment 4 Pavel Feldman 2010-03-25 00:52:24 PDT
Comment on attachment 51592 [details]
[PATCH] Prevent Beep only when handled

Clearing r+ since I think that commit message is wrong.
Comment 5 Pavel Feldman 2010-03-25 00:53:38 PDT
Comment on attachment 51592 [details]
[PATCH] Prevent Beep only when handled

Stupid me - I should have cleared cq+ only.
Comment 6 Pavel Feldman 2010-03-25 00:54:50 PDT
Re-opening the bug now that it has new title.
Comment 7 Joseph Pecoraro 2010-03-25 09:10:23 PDT
Committed r56549
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
r56549 = 03bbfd904dce03a8bf39e339c0ec9666abbdfb48 (trunk)
http://trac.webkit.org/changeset/56549