[Qt] Missing QWebSettings for Frame Flattening
Created attachment 51539 [details] Patch
This same setting will also set iFrame Flattening when available.
Looks good, but it would be nice if one from the doc team could review the documentation. Simon, could you get one to do that?
(In reply to comment #3) > Looks good, but it would be nice if one from the doc team could review the > documentation. > > Simon, could you get one to do that? Yes, this would be nice. Also I noticed that documentation for QWebSettings:WebGL is missing. Should I open a bug report for that or the doc team is working on this?! thanks for the review!
Comment on attachment 51539 [details] Patch Clearing flags on attachment: 51539 Committed r56473: <http://trac.webkit.org/changeset/56473>
All reviewed patches have been landed. Closing bug.
Guys, you broke ( but most of all fix :) ) fast/frames/flattening/frameset-flattening-grid.html with this patch http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html Could you update the platform specific expected file if the new result is correct?
(In reply to comment #7) > Guys, you broke ( but most of all fix :) ) > fast/frames/flattening/frameset-flattening-grid.html with this patch > http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html > > Could you update the platform specific expected file if the new result is > correct? diego found the problem, got a patch, kenneth reviewed and i landed. r56547
(In reply to comment #8) > (In reply to comment #7) > > Guys, you broke ( but most of all fix :) ) > > fast/frames/flattening/frameset-flattening-grid.html with this patch > > http://build.webkit.org/results/Qt%20Linux%20Release/r56474%20%289010%29/results.html > > > > Could you update the platform specific expected file if the new result is > > correct? > > diego found the problem, got a patch, kenneth reviewed and i landed. > > r56547 Leopard is still broken. The patch you committed did not reference this bug. :(
(In reply to comment #9) > Leopard is still broken. > > The patch you committed did not reference this bug. :( Needless newline removed by http://trac.webkit.org/changeset/56561 and Leopard is green again.
cherry-pick-for-backport: <r56547> cherry-pick-for-backport: <r56561>
cherry-pick-for-backport: <r56561>
cherry-pick-for-backport: <r56557>
Revision r56473 cherry-picked into qtwebkit-2.0 with commit 289b7bf993b1cb6c896142c868c674925182a197
Revision r56547 cherry-picked into qtwebkit-2.0 with commit c4fe1ca4a566b93a2f35a0d112fc1b2da12ba2dc
Revision r56557 cherry-picked into qtwebkit-2.0 with commit 9b559418e4e199551fb30218390d03e596f80f9b
Revision r56561 cherry-picked into qtwebkit-2.0 with commit 1989edbb25a211a0638ff8369999e02d254c8630