We need a #define in qtwebkitglobal.h that contains the version of QtWebKit, so that application developers can detect it.
We might need to change our User Agent as well as it currently shows the Qt version. I do not know if this still makes sense.
Created attachment 51957 [details] Proposed patch Is something like this patch the required?
Comment on attachment 51957 [details] Proposed patch Thanks Diego!!
Jocelyn, Tor Arne: Would be great if you could double check this trivial patch. Thanks :) I recall discussing the name/location of this macro, but it doesn't hurt to double check.
(In reply to comment #4) > Jocelyn, Tor Arne: Would be great if you could double check this trivial patch. > Thanks :) > > I recall discussing the name/location of this macro, but it doesn't hurt to > double check. I remember having a concern about the ambiguity of QtWebKit's version vs. WebKit's version. The function to get the WebKit's version is called qWebKitVersion(). I would prefer these macros to be called QTWEBKIT_VERSION, QT_WEBKIT_VERSION, QQTWEBKIT_VERSION or QWEBKIT_QTWEBKIT_VERSION instead of QWEBKIT_VERSION.
> I would prefer these macros to be called QTWEBKIT_VERSION, QT_WEBKIT_VERSION, > QQTWEBKIT_VERSION or QWEBKIT_QTWEBKIT_VERSION instead of QWEBKIT_VERSION. So, in this case I vote for QT_WEBKIT_VERSION. What do you thing guys?
Created attachment 52331 [details] Changed to use QT_WEBKIT_VERSION using QT_WEBKIT_VERSION
Comment on attachment 51957 [details] Proposed patch Looks like there was a new version of this patch posted. Obsoleting this one.
Created attachment 52632 [details] Using QTWEBKIT
Comment on attachment 52632 [details] Using QTWEBKIT Clearing flags on attachment: 52632 Committed r57155: <http://trac.webkit.org/changeset/57155>
All reviewed patches have been landed. Closing bug.
Revision r57155 cherry-picked into qtwebkit-2.0 with commit ce3cdb4157cea4f4d80e6498307ea65de2c36b93