RESOLVED FIXED 36537
fast/parser/comments.html needs some clean-up 
https://bugs.webkit.org/show_bug.cgi?id=36537
Summary fast/parser/comments.html needs some clean-up
Julien Chaffraix
Reported 2010-03-24 09:41:24 PDT
Looking at the output of the test, we could switch to dumpAsText. The output is confusing and some of the test is actually commented! Patch forthcoming
Attachments
Take one: clean-up output, make all part of the test run and make it a dumpAsText test (13.30 KB, patch)
2010-03-24 09:47 PDT, Julien Chaffraix 		darin: review-
jchaffraix: commit-queue-
DetailsFormatted DiffDiff
Take two: now with the expectd file (14.06 KB, patch)
2010-03-25 07:10 PDT, Julien Chaffraix 		darin: review+
jchaffraix: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2010-03-24 09:47:29 PDT
Created attachment 51515 [details] Take one: clean-up output, make all part of the test run and make it a dumpAsText test
Darin Adler
Comment 2 2010-03-24 11:28:11 PDT
Comment on attachment 51515 [details] Take one: clean-up output, make all part of the test run and make it a dumpAsText test Change looks fine, but I do not see the new expected.txt file. You need to svn add that and make a new patch.
Julien Chaffraix
Comment 3 2010-03-25 07:10:19 PDT
Created attachment 51636 [details] Take two: now with the expectd file
Julien Chaffraix
Comment 4 2010-03-30 07:14:05 PDT
Landed in r56783.
Note You need to log in before you can comment on or make changes to this bug.