Bug 36537 - fast/parser/comments.html needs some clean-up
Summary: fast/parser/comments.html needs some clean-up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Minor
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-24 09:41 PDT by Julien Chaffraix
Modified: 2010-03-30 07:14 PDT (History)
0 users

See Also:

Attachments
Take one: clean-up output, make all part of the test run and make it a dumpAsText test (13.30 KB, patch)
2010-03-24 09:47 PDT, Julien Chaffraix 		darin: review-
jchaffraix: commit-queue-
Details | Formatted Diff | Diff
Take two: now with the expectd file (14.06 KB, patch)
2010-03-25 07:10 PDT, Julien Chaffraix 		darin: review+
jchaffraix: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2010-03-24 09:41:24 PDT 
Looking at the output of the test, we could switch to dumpAsText. The output is confusing and some of the test is actually commented!

Patch forthcoming
Comment 1 Julien Chaffraix 2010-03-24 09:47:29 PDT 
Created attachment 51515 [details]
Take one: clean-up output, make all part of the test run and make it a dumpAsText test
Comment 2 Darin Adler 2010-03-24 11:28:11 PDT 
Comment on attachment 51515 [details]
Take one: clean-up output, make all part of the test run and make it a dumpAsText test

Change looks fine, but I do not see the new expected.txt file. You need to svn add that and make a new patch.
Comment 3 Julien Chaffraix 2010-03-25 07:10:19 PDT 
Created attachment 51636 [details]
Take two: now with the expectd file
Comment 4 Julien Chaffraix 2010-03-30 07:14:05 PDT 
Landed in r56783.