Web Inspector: Error when highlighting JavaScript with an invalid mime type

[Alexander Pavlov (apavlov)]

- Bring up WebInspector on http://code.google.com/p/chromium/issues/list
- Open kibbles-1.3.1-comp.js in the Scripts panel
- Inspect the WebInspector

On Chromium, the console says that there was an attempt to read the property "lexCondition" of undefined in WebInspector.SourceTokenizer.prototype.getLexCondition()

The js-file mime type is reported as "application/empty" which causes the default parser to be used, even though the parsing has not been set up properly for that.

[Alexander Pavlov (apavlov)]

Created attachment 51497 [details]
[PATCH] Proposed solution

[Pavel Feldman]

Comment on attachment 51497 [details]
[PATCH] Proposed solution

+ if (resource.mimeTypeIsConsistentWithType())

If this thing returns true, we still might end up with no tokenizer. Should this code be moved to the SourceTokenizer where you could handle this case?

[Alexander Pavlov (apavlov)]

Created attachment 51506 [details]
[PATCH] Extended solution to cover all scripts, styles, and documents

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/SourceTokenizer.js
        M       WebCore/inspector/front-end/SourceView.js
        M       WebCore/inspector/front-end/TextEditorHighlighter.js
Committed r56444