Bug 36517 - svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.
Summary: svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P4 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-23 22:32 PDT by Hajime Morrita
Modified: 2010-03-24 21:58 PDT (History)
1 user (show)

See Also:


Attachments
patch v0 - this should be a trivial change (2.21 KB, patch)
2010-03-23 22:38 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
add missing change on the expectation (2.23 KB, patch)
2010-03-24 19:42 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-03-23 22:32:39 PDT
As pointed out at the comment  on Bug 31545, the contents and expectation should be more self-descriptive,
i.e. Tt should say about what to test, point bug Id or URL.
Comment 1 Hajime Morrita 2010-03-23 22:38:10 PDT
Created attachment 51478 [details]
patch v0 - this should be a trivial change
Comment 2 WebKit Commit Bot 2010-03-24 12:45:59 PDT
Comment on attachment 51478 [details]
patch v0 - this should be a trivial change

Rejecting patch 51478 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12537 test cases.
svg/dom/frame-related-api-during-load.html -> failed

Exiting early after 1 failures. 10228 tests run.
236.85s total testing time

10227 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
10 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/1288006
Comment 3 Hajime Morrita 2010-03-24 19:42:32 PDT
Created attachment 51581 [details]
add missing change on the expectation
Comment 4 Hajime Morrita 2010-03-24 19:44:28 PDT
Oops, The patch missed my local change - fixed.
I'm so sorry about that ...
Comment 5 Eric Seidel (no email) 2010-03-24 19:44:57 PDT
Comment on attachment 51581 [details]
add missing change on the expectation

OK.
Comment 6 WebKit Commit Bot 2010-03-24 21:58:25 PDT
Comment on attachment 51581 [details]
add missing change on the expectation

Clearing flags on attachment: 51581

Committed r56486: <http://trac.webkit.org/changeset/56486>
Comment 7 WebKit Commit Bot 2010-03-24 21:58:29 PDT
All reviewed patches have been landed.  Closing bug.