Bug 36492 - [Qt] websocket/tests/long-invalid-header.html fails
Summary: [Qt] websocket/tests/long-invalid-header.html fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Major
Assignee: Fumitoshi Ukai
Keywords: Qt
Depends on:
Reported: 2010-03-23 06:28 PDT by Csaba Osztrogonác
Modified: 2010-03-25 01:39 PDT (History)
6 users (show)

See Also:

Patch (8.95 KB, patch)
2010-03-23 22:38 PDT, Fumitoshi Ukai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-03-23 06:28:29 PDT
websocket/tests/long-invalid-header.html inroduced in http://trac.webkit.org/changeset/56380.
It fails on Qt bots because of different CONSOLE MESSAGE, but the 
PASS and TEST COMPLETE is correct and it passes in QtLauncher


I think the it might be a Qt-DRT bug.
Comment 1 Csaba Osztrogonác 2010-03-23 06:36:47 PDT
websocket/tests/long-invalid-header.html skipped to make bots happy: http://trac.webkit.org/changeset/56389
Comment 2 Fumitoshi Ukai 2010-03-23 22:35:10 PDT
I think the expected data depends on how data is buffered/delivered from SocketStreamHandle to WebSocketChannel,WebSocketHandshake.
I think console message doesn't need to whole data in buffer.
Comment 3 Fumitoshi Ukai 2010-03-23 22:38:45 PDT
Created attachment 51479 [details]
Comment 4 Eric Seidel (no email) 2010-03-25 01:10:56 PDT
Comment on attachment 51479 [details]

I'm surprised this wouldn't be a part of the Console classes instead of done ad-hoc for WebSocket here.

But this is OK for now I guess.
Comment 5 Eric Seidel (no email) 2010-03-25 01:11:13 PDT
CCing inspector gurus.
Comment 6 Fumitoshi Ukai 2010-03-25 01:39:16 PDT
Committed r56511: <http://trac.webkit.org/changeset/56511>