Bug 36489 – [DRT/Chromium] Add TestNavigationController and TestWebWorker

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

[DRT/Chromium] Add TestNavigationController and TestWebWorker

[Kent Tamura]

Created attachment 51415 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 51415 [details]
Patch

Why do we need TestNavigationController in its full glory in DRT? Most of its work is focused around providing a simple browser, which we don't need here.

> +
> +// ----------------------------------------------------------------------------
> +// TestNavigationEntry
> +
> +TestNavigationEntry::TestNavigationEntry()
> +    : m_pageID(-1) {}
> +
> +TestNavigationEntry::TestNavigationEntry(
> +    int pageID, const GURL& url, const WebString& title, const WebString& targetFrame)

Can we use WebURL here -- or at least put a FIXME?

> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifndef TestNavigationController_h
> +#define TestNavigationController_h
> +
> +#include "base/basictypes.h"
> +#include "base/linked_ptr.h"
> +#include "base/ref_counted.h"

It would be good to use WTF types here, but a FIXME should suffice for now.

> +#define TestWebWorker_h
> +
> +#include "base/basictypes.h"

No need for this here.

[Kent Tamura]

Created attachment 51476 [details]
Proposed patch (rev.2)

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 51415 [details])
> Why do we need TestNavigationController in its full glory in DRT? Most of its
> work is focused around providing a simple browser, which we don't need here.

We need it to produce the output of layoutTestControler.dumpBackForwardList.

> > +TestNavigationEntry::TestNavigationEntry(
> > +    int pageID, const GURL& url, const WebString& title, const WebString& targetFrame)
> 
> Can we use WebURL here -- or at least put a FIXME?

Replaced GURL with WebURL.

> > +#include "base/basictypes.h"
> > +#include "base/linked_ptr.h"
> > +#include "base/ref_counted.h"
> 
> It would be good to use WTF types here, but a FIXME should suffice for now.

Removed ref_counted.h, which was not used in this file.
I think no WTF alternative for linked_ptr.h.

> > +#define TestWebWorker_h
> > +
> > +#include "base/basictypes.h"
> 
> No need for this here.

Right. Removed.

[Dimitri Glazkov (Google)]

Comment on attachment 51476 [details]
Proposed patch (rev.2)

ok. I don't think we'll need some of the methods TestNavigationController provides, but we can refactor this later.

[Kent Tamura]

Landed as r56434.