<rdar://problem/7197736> When changes to overflow clip affect a plug-in’s visible rect, but its frame rect doesn’t change, if the plug-in is not in a compositing layer, then it does not get updated to reflect the change to clipping. This is demonstrated by a manual test which is part of a forthcoming patch.
Created attachment 51395 [details] Notify views of visible-rect-only changes
Attachment 51395 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/mac/Plugins/WebBaseNetscapePluginView.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 51395 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/981123
Created attachment 51396 [details] Notify views of visible-rect-only changes
Attachment 51396 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/mac/Plugins/WebBaseNetscapePluginView.h:52: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 51396 [details] Notify views of visible-rect-only changes > Index: WebCore/manual-tests/plugin-visible-rect-change.html > =================================================================== > --- WebCore/manual-tests/plugin-visible-rect-change.html (revision 0) > +++ WebCore/manual-tests/plugin-visible-rect-change.html (revision 0) > @@ -0,0 +1,25 @@ > +<p> > + This test requires that accelerated compositing be dsiabled Typo: "dsiabled". I'll review more later.
Oops, I r+'ed the obsolete version.
Comment on attachment 51396 [details] Notify views of visible-rect-only changes > + This test requires that accelerated compositing be dsiabled. Clicking the Test button should completely reveal the black-bordered box. > + The orange video should completely fill the box, with the controller visible and touching the bottom of the box. There should be > + not ba any red visible. r+ if you fix "dsiabled" and "ba any red".
Fixed in <http://trac.webkit.org/projects/webkit/changeset/56429> except I forgot to fix the typos in the test :-(