Bug 36441 - [v8] Inspected Page crashes in destructor when Web Inspector is open
Summary: [v8] Inspected Page crashes in destructor when Web Inspector is open
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on:
Reported: 2010-03-22 06:01 PDT by Yury Semikhatsky
Modified: 2010-04-01 13:41 PDT (History)
1 user (show)

See Also:

patch (1.00 KB, patch)
2010-03-22 06:15 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-03-22 06:01:07 PDT
Inspected Page crashes in destructor when Web Inspector is open. It's a regression appeared after http://trac.webkit.org/changeset/56051 because InjectDispatch.js doesn't have method inspectedPageDestroyed.

0x025b6c44	 [chrome.dll	 - execution.cc:98]	v8::internal::Invoke
0x025b6d25	 [chrome.dll	 - execution.cc:124]	v8::internal::Execution::Call(v8::internal::Handle<v8::internal::JSFunction>,v8::internal::Handle<v8::internal::Object>,int,v8::internal::Object * * *,bool *)
0x0258b91d	 [chrome.dll	 - api.cc:2481]	v8::Function::Call(v8::Handle<v8::Object>,int,v8::Handle<v8::Value> * const)
0x021365fa	 [chrome.dll	 - scriptfunctioncall.cpp:140]	WebCore::ScriptFunctionCall::call(bool &,bool)
0x02136653	 [chrome.dll	 - scriptfunctioncall.cpp:152]	WebCore::ScriptFunctionCall::call()
0x01fb65a9	 [chrome.dll	 - page.cpp:196]	WebCore::Page::~Page()
0x02241e32	 [chrome.dll	 - webviewimpl.cpp:841]	WebKit::WebViewImpl::close()
0x01d2ed9b	 [chrome.dll	 - render_widget.cc:650]	RenderWidget::Close()
0x01d132e6	 [chrome.dll	 - render_view.cc:4574]	RenderView::Close()
0x01d30112	 [chrome.dll	 - task.h:296]	RunnableMethod<RenderWidget,void ( RenderWidget::*)(void),Tuple0>::Run()
0x01ce30d8	 [chrome.dll	 - message_loop.cc:329]	MessageLoop::RunTask(Task *)
0x01ce3112	 [chrome.dll	 - message_loop.cc:337]	MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const &)
0x01ce32c7	 [chrome.dll	 - message_loop.cc:444]	MessageLoop::DoWork()
0x01cf2f4f	 [chrome.dll	 - message_pump_default.cc:50]	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x01ce2f88	 [chrome.dll	 - message_loop.cc:205]	MessageLoop::RunInternal()
0x01ce2f0d	 [chrome.dll	 - message_loop.cc:177]	MessageLoop::RunHandler()
0x01ce2ebe	 [chrome.dll	 - message_loop.cc:155]	MessageLoop::Run()
0x01cfcad2	 [chrome.dll	 - renderer_main.cc:277]	RendererMain(MainFunctionParams const &)
0x01c33947	 [chrome.dll	 - chrome_dll_main.cc:708]	ChromeMain
0x004031bd	 [chrome.exe	 - client_util.cc:195]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x00403860	 [chrome.exe	 - chrome_exe_main.cc:48]	wWinMain
0x00428b2a	 [chrome.exe	 - crt0.c:324]	__tmainCRTStartup
0x7c817076	 [kernel32.dll	 + 0x00017076]	BaseProcessStart
Comment 1 Yury Semikhatsky 2010-03-22 06:15:31 PDT
Created attachment 51278 [details]

I'd like to write a test for this but it would require adding a method to LayoutTestController that would allow to close inspected page. I'd rather commit the fix first.
Comment 2 Yury Semikhatsky 2010-03-22 06:26:40 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/InjectDispatch.js
Committed r56332