RESOLVED WONTFIX36438
Use "-f" option instead of "--force" for git rm. 
https://bugs.webkit.org/show_bug.cgi?id=36438
Summary Use "-f" option instead of "--force" for git rm.
Csaba Osztrogonác
Reported 2010-03-22 04:17:31 PDT
WebKitTools/Scripts/svn-apply pass "--force" option to git rm. Unfortunately earlier (Debian Lenny - git version 1.5.6.5) versions of git don't know --force, only -f. Newer git versions know both of them. I propose we should use -f instead of --force.
Attachments
proposed patch (978 bytes, patch)
2010-03-22 04:26 PDT, Csaba Osztrogonác 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-03-22 04:26:52 PDT
Created attachment 51274 [details] proposed patch
Eric Seidel (no email)
Comment 2 2010-03-22 10:22:29 PDT
Comment on attachment 51274 [details] proposed patch Lame. We should document what minimum version of git scm.py and this file are expected to support. This change also needs a comment explaining why it's -f so that someone doesn't later change it back to --force. Can we unit test this? I guess not easily given the current design of the perl scripts. r- mostly because this needs a comment/further documentation in the file, and I don't believe this is a full fix (does scm.py need a similar fix?)
Zoltan Horvath
Comment 3 2010-06-17 05:02:54 PDT
Git has contained --force option since 2008 (GIT v1.6.0.x). Actually, the latest stable Git version is 1.7.1. I think it's easier to update git than adding unnecessary changes and unit tests. (Furthermore, v1.6 and v1.7 contains significant performance improvements which are beneficial - especially - for large trees like WebKit.)
Csaba Osztrogonác
Comment 4 2012-05-24 06:31:00 PDT
Debian Squeeze has 1.7.2.5 GIT version, so we don't need this change anymore.
Note You need to log in before you can comment on or make changes to this bug.