Bug 36413 – [Qt] RenderTheme: fix size adjustment for text fields

• Status: CLOSED
• Resolution: FIXED
• Component: Forms

[Jakub Wieczorek]

RenderThemeQt.cpp "hardcodes" the preferred dimensions for text fields but in fact it is not necessary, because WebCore already does that (20 cols x 2 rows for text areas and 20 cols x 1 row for text fields). To match other ports the size shouldn't be altered by the render theme, I believe.

Moreover, the padding for text fields is not properly applied:
- RenderTheme should also change the horizontal padding.
- it should work the same for text areas - it does not now, which causes rendering issues with the Oxygen style.

[Jakub Wieczorek]

Created attachment 51222 [details]
patch

With this change, 3 test results had to be updated but I'm not sure if there isn't anything left to update.

[Giacomo]

Is this related to: https://bugs.webkit.org/show_bug.cgi?id=36030 ?

[Simon Hausmann]

Tor Arne, could you take a look at this one?

Thanks :)

[Eric Seidel (no email)]

Comment on attachment 51222 [details]
patch

OK.

[Jakub Wieczorek]

Comment on attachment 51222 [details]
patch

Clearing flags on attachment: 51222

Committed r56555: <http://trac.webkit.org/changeset/56555>

[Jakub Wieczorek]

All reviewed patches have been landed.  Closing bug.

[Giacomo]

*** Bug 36030 has been marked as a duplicate of this bug. ***

[Simon Hausmann]

Revision r56555 cherry-picked into qtwebkit-2.0 with commit cd23c453d081a795f63d594e3da8b2b580726ab7