Bug 36405 - [EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
Summary: [EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 20:56 PDT by Laszlo Gombos
Modified: 2010-04-08 09:10 PDT (History)
6 users (show)

See Also:

Attachments
(committed in r57282) patch v1 (4.38 KB, patch)
2010-04-08 08:46 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-03-19 20:56:08 PDT 
Regarding ChangeSet r55343 (http://trac.webkit.org/changeset/55343) - Shouldn't AccessibilityObjectEfl.cpp be under accessibility directory like for other ports (e.g WebCore/accessibility/platform/efl) ?
Comment 1 Laszlo Gombos 2010-03-19 20:57:09 PDT 
I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl.
Comment 2 David Kilzer (:ddkilzer) 2010-04-07 09:47:59 PDT 
(In reply to comment #1)
> I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl.

Yes, it should be moved to WebCore/accessibility/efl/.
Comment 3 Gustavo Sverzut Barbieri 2010-04-07 14:27:39 PDT 
Could someone move it then? The build system is still not integrated (#36761), then we could provide a new patch for build system with the correct path.
Comment 4 David Kilzer (:ddkilzer) 2010-04-08 08:29:43 PDT 
(In reply to comment #3)
> Could someone move it then? The build system is still not integrated (#36761),
> then we could provide a new patch for build system with the correct path.

Anyone can post a patch to move the file.
Comment 5 Antonio Gomes 2010-04-08 08:41:33 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Could someone move it then? The build system is still not integrated (#36761),
> > then we could provide a new patch for build system with the correct path.
> 
> Anyone can post a patch to move the file.

as agreed on IRC w/ k-s (gustavo barbieri) i will do that now
Comment 6 Antonio Gomes 2010-04-08 08:46:24 PDT 
Created attachment 52871 [details]
(committed in r57282) patch v1
Comment 7 Laszlo Gombos 2010-04-08 08:52:14 PDT 
Comment on attachment 52871 [details]
(committed in r57282) patch v1

Looks good to me.
Comment 8 Antonio Gomes 2010-04-08 09:09:59 PDT 
Comment on attachment 52871 [details]
(committed in r57282) patch v1

thank you laszlo!

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	R	WebCore/page/efl/AccessibilityObjectEfl.cpp => WebCore/accessibility/efl/AccessibilityObjectEfl.cpp
	M	WebCore/ChangeLog
Committed r57282