In debug mode we are compiling with GTK_NO_DEPRECATED and with Gtk+ 2.20 we are using deprecated symbols.
Created attachment 51213 [details] Use non depcreated variants for the GtkWidget GTK_WIDGET_REALIZED and GTK_WIDGET_NO_WINDOW are deprecated. For the GTK_WIDGET_NO_WINDOW case we need to use gtk_widget_get_has_window which actually returns _if_ we have a window, this means we need to negate that.
Attachment 51213 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/977055
Created attachment 51217 [details] Use the right version Gtk Version The new methods were added in 2.19... correct the GTK_CHECK_VERSION for that.
Attachment 51217 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/plugins/gtk/gtk2xtbin.c:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:465: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:465: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Holger, I have an alternate proposal at https://bugs.webkit.org/show_bug.cgi?id=36398 What do you think?
And yeah, it needs the same realized fix still, didn't get time to get to it yet, will fix the patch tonight.
Since zecke told me he thinks my patch is good, I'll mark this as a duplicate of the bug I opened. *** This bug has been marked as a duplicate of bug 36398 ***
Comment on attachment 51217 [details] Use the right version Gtk Version clearing r? on this closed bug.