Bug 36401 - re-enable downstream overrides for chromium ports in new-run-webkit-tests
Summary: re-enable downstream overrides for chromium ports in new-run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 18:18 PDT by Dirk Pranke
Modified: 2010-03-20 10:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2010-03-19 18:20 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
sample downstream overrides file for test_expectations (298 bytes, text/plain)
2010-03-19 18:22 PDT, Dirk Pranke 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-03-19 18:18:42 PDT 
undoing part of the change in bug 36396 / r56287 - we need to re-enable the downstream/chromium.org test_expectations file so that we can suppress errors without needing a webkit roll.
Comment 1 Dirk Pranke 2010-03-19 18:20:34 PDT 
Created attachment 51209 [details]
Patch
Comment 2 Dirk Pranke 2010-03-19 18:22:30 PDT 
Created attachment 51210 [details]
sample downstream overrides file for test_expectations

Dimitri - I suggest that when we zero-out the downstream test_expectations.txt file we replace it with something like the attached.
Comment 3 Ojan Vafai 2010-03-19 18:23:43 PDT 
LGTM
Comment 4 Dimitri Glazkov (Google) 2010-03-20 10:15:54 PDT 
Comment on attachment 51209 [details]
Patch

Let's do it!
Comment 5 Dimitri Glazkov (Google) 2010-03-20 10:21:30 PDT 
Comment on attachment 51209 [details]
Patch

Clearing flags on attachment: 51209

Committed r56306: <http://trac.webkit.org/changeset/56306>
Comment 6 Dimitri Glazkov (Google) 2010-03-20 10:21:36 PDT 
All reviewed patches have been landed.  Closing bug.