Bug 36390 - [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
Summary: [GTK] suppress (un)desired launcher output that can make layout test to fail ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 14:19 PDT by Martin Robinson
Modified: 2010-03-29 21:04 PDT (History)
0 users

See Also:


Attachments
Patch for this issue (1.93 KB, patch)
2010-03-19 14:29 PDT, Martin Robinson
eric: review-
mrobinson: commit-queue-
Details | Formatted Diff | Diff
Patch for this issue (rev2) (2.21 KB, patch)
2010-03-25 09:12 PDT, Martin Robinson
zecke: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-03-19 14:19:40 PDT
Very similar to: https://bugs.webkit.org/show_bug.cgi?id=27215

The Totem plugin, in particular can cause spurious failures when it uses the GLib logger.
Comment 1 Martin Robinson 2010-03-19 14:29:40 PDT
Created attachment 51188 [details]
Patch for this issue
Comment 2 Eric Seidel (no email) 2010-03-25 00:51:49 PDT
Comment on attachment 51188 [details]
Patch for this issue

We need a comment in the code, otherwise the next person to look at this will have no clue what this is for.
Comment 3 Martin Robinson 2010-03-25 09:12:07 PDT
Created attachment 51645 [details]
Patch for this issue (rev2)

Sounds good. Update attached.
Comment 4 Holger Freyther 2010-03-28 19:39:15 PDT
Comment on attachment 51645 [details]
Patch for this issue (rev2)

Yes, this will work for the totem plugin. Some how my memory tells me we had a patch to run-webkit-test to filter out certain output but my memory seems to play tricks...
Comment 5 Martin Robinson 2010-03-29 21:04:52 PDT
Committed r56760: <http://trac.webkit.org/changeset/56760>