Bug 36389 - [Qt] Remove support for Qt v4.4
Summary: [Qt] Remove support for Qt v4.4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Laszlo Gombos
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-03-19 14:06 PDT by Laszlo Gombos
Modified: 2010-03-23 05:52 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (12.74 KB, patch)
2010-03-19 14:23 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-03-19 14:06:50 PDT
Support for 4.4 should be removed.
Comment 1 Laszlo Gombos 2010-03-19 14:23:50 PDT
Created attachment 51187 [details]
proposed patch
Comment 2 Jędrzej Nowacki 2010-03-22 07:25:11 PDT
I have found another places, for example

WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500

I suggest to run 'git grep "QT_VERSION"' to find more :-)
Comment 3 Jędrzej Nowacki 2010-03-22 09:06:08 PDT
(In reply to comment #2)
> I have found another places, for example
> 
> WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
> WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500
> 
> I suggest to run 'git grep "QT_VERSION"' to find more :-)

Sorry, I just skipped two of them. 

Looks good to me.
Comment 4 Simon Hausmann 2010-03-22 15:23:36 PDT
Assigning to Laszlo, so it doesn't show up in the list of untriaged bugs. This one is triaged :)
Comment 5 WebKit Commit Bot 2010-03-23 05:52:25 PDT
Comment on attachment 51187 [details]
proposed patch

Clearing flags on attachment: 51187

Committed r56386: <http://trac.webkit.org/changeset/56386>
Comment 6 WebKit Commit Bot 2010-03-23 05:52:29 PDT
All reviewed patches have been landed.  Closing bug.