RESOLVED FIXED 36389
[Qt] Remove support for Qt v4.4 
https://bugs.webkit.org/show_bug.cgi?id=36389
Summary [Qt] Remove support for Qt v4.4
Laszlo Gombos
Reported Friday, March 19, 2010 10:06:50 PM UTC
Support for 4.4 should be removed.
Attachments
proposed patch (12.74 KB, patch)
2010-03-19 14:23 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 Friday, March 19, 2010 10:23:50 PM UTC
Created attachment 51187 [details] proposed patch
Jędrzej Nowacki
Comment 2 Monday, March 22, 2010 3:25:11 PM UTC
I have found another places, for example WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500 I suggest to run 'git grep "QT_VERSION"' to find more :-)
Jędrzej Nowacki
Comment 3 Monday, March 22, 2010 5:06:08 PM UTC
(In reply to comment #2) > I have found another places, for example > > WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 > WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 > WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500 > > I suggest to run 'git grep "QT_VERSION"' to find more :-) Sorry, I just skipped two of them. Looks good to me.
Simon Hausmann
Comment 4 Monday, March 22, 2010 11:23:36 PM UTC
Assigning to Laszlo, so it doesn't show up in the list of untriaged bugs. This one is triaged :)
WebKit Commit Bot
Comment 5 Tuesday, March 23, 2010 1:52:25 PM UTC
Comment on attachment 51187 [details] proposed patch Clearing flags on attachment: 51187 Committed r56386: <http://trac.webkit.org/changeset/56386>
WebKit Commit Bot
Comment 6 Tuesday, March 23, 2010 1:52:29 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.