Bug 36387 - REGRESSION: Can "uncheck" radio buttons by clicking on them
Summary: REGRESSION: Can "uncheck" radio buttons by clicking on them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 13:48 PDT by Simon Fraser (smfr)
Modified: 2010-03-19 16:42 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.63 KB, patch)
2010-03-19 16:10 PDT, Simon Fraser (smfr) 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-03-19 13:48:49 PDT 
http://trac.webkit.org/changeset/56174/ broke radio buttons. You can now uncheck the only checked radio button by clicking on it.
Comment 1 Simon Fraser (smfr) 2010-03-19 16:10:40 PDT 
Created attachment 51200 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-03-19 16:16:46 PDT 
Comment on attachment 51200 [details]
Patch

r=me with nits:

> +    if (window.layoutTestController)
> +      layoutTestController.dumpAsText();
> +
> +    function dispatchEvent(target, eventType, offsetX, offsetY)
> +    {

two-space indent? :)

> +</body>
> +</html>
> \ No newline at end of file

add extra line break.

>              // As a way to store the state, we return 0 if we were unchecked, 1 if we were checked, and 2 for
>              // indeterminate.

remove that comment.

Comment 3 Simon Fraser (smfr) 2010-03-19 16:42:44 PDT 
http://trac.webkit.org/changeset/56284