Bug 36362 - Web Inspector: editing shorthands does not always work.
Summary: Web Inspector: editing shorthands does not always work.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-03-19 05:54 PDT by Pavel Feldman
Modified: 2010-03-19 06:35 PDT (History)
4 users (show)

See Also:

[PATCH] Proposed fix. (9.56 KB, patch)
2010-03-19 05:58 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-19 05:54:05 PDT
Editing value markup (that is converted to an editable field) produces &nbsp; (0xA0) instead of space (0x20) character in the areas that are siblings to the markup spans. I.e. instead of "3px <span>5px</span>", we get "3px&nbsp;<span>...". Native code that is assigning textContent of such a value to style fails.

Drive-by fixes in the patch are: 
- restored fallback for shorthand property getter
- made enable/disable checkbox visible when unckecked regardless of the hover state. This allows distinguishing of the overriden values vs manually disabled ones.
Comment 1 Pavel Feldman 2010-03-19 05:58:59 PDT
Created attachment 51147 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2010-03-19 06:35:25 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.css
Committed r56237