Bug 36348 - [Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
Summary: [Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-03-19 00:16 PDT by Laszlo Gombos
Modified: 2010-03-19 09:42 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.30 KB, patch)
2010-03-19 00:21 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-03-19 00:16:59 PDT 
It seems that the QtWebKit tiled backing store needs the QGraphicsItem::scale function (seeQGraphicsWebViewPrivate::updateTiledBackingStoreScale).

I propose to turn off TILED_BACKING_STORE if Qt version is earlier than Qt4.6 (instead of making it work on Qt 4.5 or earlier).
Comment 1 Laszlo Gombos 2010-03-19 00:21:11 PDT 
Created attachment 51130 [details]
proposed patch
Comment 2 Simon Hausmann 2010-03-19 00:35:41 PDT 
QGraphicsItem::scale is present in Qt 4.5, but it's not a Q_PROPERTY in QGraphicsObject.
Comment 3 Antonio Gomes 2010-03-19 08:49:56 PDT 
i confess I do not know what is the current minimum version of Qt that QtWebKit has to support. 

one mentioned it is current release (4.6) and the next (4.7). If so, should we care much about 4.5?

just out of curiosity.
Comment 4 WebKit Commit Bot 2010-03-19 09:41:55 PDT 
Comment on attachment 51130 [details]
proposed patch

Clearing flags on attachment: 51130

Committed r56243: <http://trac.webkit.org/changeset/56243>
Comment 5 WebKit Commit Bot 2010-03-19 09:42:00 PDT 
All reviewed patches have been landed.  Closing bug.