[chromium] querying the current HistoryItem during a back/forward navigation causes loss of scroll offset and other state

[Darin Fisher (:fishd, Google)]

[chromium] querying the current HistoryItem during a back/forward
navigation causes loss of scroll offset and other state

which explains bugs like this:
http://code.google.com/p/chromium/issues/detail?id=12084

chrome periodically records the current history item for crash
recovery purposes, but that actually causes loss of data if the
page the user is navigating back to is even slightly slow to load.

[Darin Fisher (:fishd, Google)]

Created attachment 51131 [details]
v1 patch

The basic fix here is to suppress updating the current history item while we are still loading.  I decided to exclude normal, new navigations since a user might start interacting with the page before it is fully loaded.  Obviously, this could be the case for other types of navigations as well, so there may be a better overall solution.  This patch is however a significant improvement for a pretty nasty data-loss bug.

[Dimitri Glazkov (Google)]

Comment on attachment 51131 [details]
v1 patch

nice find!

Can this be regression-proofed with a test?

[Darin Fisher (:fishd, Google)]

It would require an API test.  I was going to add such a test to Chromium.

[Dimitri Glazkov (Google)]

Sounds good.

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/56244