What steps will reproduce the problem? 1. Change screen resolution to 800 X 600 2. Goto http://vopium.com/handsets and click on "Select brand" drop down The drop-down does not fit on the screen.
Created attachment 51124 [details] Max size select patch
Attachment 51124 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/chromium/PopupMenuChromium.cpp:358: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/chromium/PopupMenuChromium.cpp:367: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 51125 [details] Fixing style issue
Comment on attachment 51125 [details] Fixing style issue > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 56212) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2010-03-18 Jay Campan <jcampan@google.com> > + There should be a "Reviewed by NOBODY (OOPS!)" line here to make the commit queue happy. Be sure to add a Reviewed by line before manually committing. R=me
Created attachment 51135 [details] Fixing ChangeLog file Added back the "Reviewed by ..." line in the ChangeLog that I had accidentally removed.
Comment on attachment 51135 [details] Fixing ChangeLog file Basically just applying Darin Fisher's r+ to this patch as I verified that the only difference is the "Reviewed by NOBODY (OOPS!)." line.
Comment on attachment 51135 [details] Fixing ChangeLog file Rejecting patch 51135 from commit-queue. Failed to parse ChangeLog: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog
Leading junk in the ChangeLog. Not sure what it is.
Created attachment 51367 [details] Fixed ChangeLog Fixed the ChangeLog (not sure what the chars in there were).
Comment on attachment 51125 [details] Fixing style issue Cleared Darin Fisher's review+ from obsolete attachment 51125 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 51135 [details] Fixing ChangeLog file Cleared David Levin's review+ from obsolete attachment 51135 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 51367 [details] Fixed ChangeLog OK. Sad we can't test this.
Comment on attachment 51367 [details] Fixed ChangeLog Rejecting patch 51367 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: e WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/chromium/PopupMenuChromium.cpp Hunk #1 succeeded at 144 with fuzz 2 (offset 3 lines). Hunk #2 FAILED at 159. Hunk #3 succeeded at 249 with fuzz 2 (offset 5 lines). Hunk #4 succeeded at 339 with fuzz 2 (offset 12 lines). Hunk #5 FAILED at 354. Hunk #6 succeeded at 452 (offset 31 lines). Hunk #7 FAILED at 1218. 3 out of 7 hunks FAILED -- saving rejects to file WebCore/platform/chromium/PopupMenuChromium.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/1279024
This was already landed.