Bug 36333 - [Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT
Summary: [Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Blocker
Assignee: Bernhard Rosenkraenzer
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-03-18 16:05 PDT by Bernhard Rosenkraenzer
Modified: 2010-11-10 12:38 PST (History)
2 users (show)

See Also:

Attachments
Fix (782 bytes, patch)
2010-03-18 16:08 PDT, Bernhard Rosenkraenzer 		hausmann: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Rosenkraenzer 2010-03-18 16:05:08 PDT 
platform/qt/WheelEventQt.cpp: In member function âvoid WebCore::PlatformWheelEvent::applyDelta(int, Qt::Orientation)â:
platform/qt/WheelEventQt.cpp:48:17: error: âwheelScrollLinesâ is not a member of âQApplicationâ
platform/qt/WheelEventQt.cpp:49:17: error: âwheelScrollLinesâ is not a member of âQApplicationâ
Comment 1 Bernhard Rosenkraenzer 2010-03-18 16:08:48 PDT 
Created attachment 51109 [details]
Fix
Comment 2 Simon Hausmann 2010-03-19 00:34:46 PDT 
Comment on attachment 51109 [details]
Fix

Bero, your patch is fine in general, but it's missing a ChangeLog.

I'd also move the #ifdef _into_ the {} set, instead of creating a new set of parentheses.
Comment 3 Benjamin Poulain 2010-11-10 12:38:45 PST 
Closing. This has been fixed by İsmail Dönmez in r51425: http://trac.webkit.org/changeset/51425