WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36333
[Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT
https://bugs.webkit.org/show_bug.cgi?id=36333
Summary
[Qt] WebKit fails to build if Qt is built with QT_NO_WHEELEVENT
Bernhard Rosenkraenzer
Reported
2010-03-18 16:05:08 PDT
platform/qt/WheelEventQt.cpp: In member function âvoid WebCore::PlatformWheelEvent::applyDelta(int, Qt::Orientation)â: platform/qt/WheelEventQt.cpp:48:17: error: âwheelScrollLinesâ is not a member of âQApplicationâ platform/qt/WheelEventQt.cpp:49:17: error: âwheelScrollLinesâ is not a member of âQApplicationâ
Attachments
Fix
(782 bytes, patch)
2010-03-18 16:08 PDT
,
Bernhard Rosenkraenzer
hausmann
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Bernhard Rosenkraenzer
Comment 1
2010-03-18 16:08:48 PDT
Created
attachment 51109
[details]
Fix
Simon Hausmann
Comment 2
2010-03-19 00:34:46 PDT
Comment on
attachment 51109
[details]
Fix Bero, your patch is fine in general, but it's missing a ChangeLog. I'd also move the #ifdef _into_ the {} set, instead of creating a new set of parentheses.
Benjamin Poulain
Comment 3
2010-11-10 12:38:45 PST
Closing. This has been fixed by İsmail Dönmez in
r51425
:
http://trac.webkit.org/changeset/51425
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug