Bug 36332 – Compilation error, when not enabling plugins

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Plug-ins

[Yuval Tal]

Building with QT without plugins, you get an error of a method which has no declaration. This will fix it:

Index: WebCore/plugins/PluginView.cpp
===================================================================
--- WebCore/plugins/PluginView.cpp	(revision 56179)
+++ WebCore/plugins/PluginView.cpp	(working copy)
@@ -1298,6 +1298,7 @@
 }
 #endif
 
+#if ENABLE(NETSCAPE_PLUGIN_API)
 NPError PluginView::getValueStatic(NPNVariable variable, void* value)
 {
     LOG(Plugins, "PluginView::getValueStatic(%s)", prettyNameForNPNVariable(variable).data());
@@ -1308,6 +1309,7 @@
 
     return NPERR_GENERIC_ERROR;
 }
+#endif
 
 NPError PluginView::getValue(NPNVariable variable, void* value)
 {

[Julien Chaffraix]

Thanks for the patch. Looking at it, it seems that you have forgotten to patch PluginViewNone.cpp too.

If you want your change to be integrated, you should follow http://webkit.org/coding/contributing.html. Mostly you will need to add a ChangeLog, put the patch as an attachment and set the review flag to '?'.

[Yuval Tal]

Created attachment 51257 [details]
Fixes compilation and link errors when compiling with Qt on linux without plugin support

[Yuval Tal]

Comment on attachment 51257 [details]
Fixes compilation and link errors when compiling with Qt on linux without plugin support

First thing in this patch is to fix compile/link errors on Qt when there's no plugins enabled. Another small patch here, is in case where you have pcre.h in your system include directories, which causes webkit compile to fail. Simple fix in the include name does the trick.

[Eric Seidel (no email)]

Comment on attachment 51257 [details]
Fixes compilation and link errors when compiling with Qt on linux without plugin support

Please fill in the ChangeLog templates to explain your change.

See http://webkit.org/coding/contributing.html for more information.

[Ahmad Saleem]

Qt framework builds are not supported anymore and Plugins support at least NPAPI was now removed since Safari 14 and Webkit Plugins were not supported since Safari 5. I think this can be closed as "RESOLVED WONTFIX". Thanks!