Bug 36331 - Fails to build when pcre.h is present in /usr/local/include
Summary: Fails to build when pcre.h is present in /usr/local/include
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-18 15:47 PDT by Yuval Tal
Modified: 2024-03-11 05:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuval Tal 2010-03-18 15:47:36 PDT 
Building with QT, my spec points adds -I/usr/local/include which has pcre.h. Compilation fails, since you include <pcre.h>, which means the pcre.h in WebKit. This fixes it:

Index: JavaScriptCore/yarr/RegexJIT.h
===================================================================
--- JavaScriptCore/yarr/RegexJIT.h	(revision 56179)
+++ JavaScriptCore/yarr/RegexJIT.h	(working copy)
@@ -32,7 +32,7 @@
 #include "RegexPattern.h"
 #include <UString.h>
 
-#include <pcre.h>
+#include <pcre/pcre.h>
 struct JSRegExp; // temporary, remove when fallback is removed.
 
 #if CPU(X86) && !COMPILER(MSVC)
Comment 1 Ahmad Saleem 2024-03-11 05:50:38 PDT 
QT port is gone now. There is work done on upstream to revive it but I can't find this header via searchfox.org, so it might not be required.

Changing to 'RESOLVED WONTFIX' because it was never confirmed.