Bug 36324 - new-run-webkit-tests needs to be able to find Chromium baselines upstream as well as downstream
Summary: new-run-webkit-tests needs to be able to find Chromium baselines upstream as ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-18 14:31 PDT by Dirk Pranke
Modified: 2010-03-18 15:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.91 KB, patch)
2010-03-18 14:34 PDT, Dirk Pranke
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-03-18 14:31:27 PDT
We are getting ready to land all of the Chromium LayoutTest baselines upstream, and so we need to modify the new-run-webkit-tests infrastructure to look for them upstream as well as downstream (downstream expectations trump upstream ones).
Comment 1 Dirk Pranke 2010-03-18 14:34:01 PDT
Created attachment 51094 [details]
Patch
Comment 2 Ojan Vafai 2010-03-18 14:46:55 PDT
Comment on attachment 51094 [details]
Patch

Please put in FIXMEs to remove the chromium_baseline_path calls once the baselines are all moved upstream. Otherwise, lgtm.
Comment 3 Dirk Pranke 2010-03-18 15:22:39 PDT
(In reply to comment #2)
> (From update of attachment 51094 [details])
> Please put in FIXMEs to remove the chromium_baseline_path calls once the
> baselines are all moved upstream. Otherwise, lgtm.

I'm not actually 100% sure that we won't want to keep the downstream paths around in case we need to (temporarily) check in downstream baselines. But, it's probably safer for the gardeners if we don't make this possible out of the gate, so I will do as you say. We can always add this back in if we need it.
Comment 4 Dimitri Glazkov (Google) 2010-03-18 15:38:27 PDT
Comment on attachment 51094 [details]
Patch

rs=me.
Comment 5 Dirk Pranke 2010-03-18 15:45:36 PDT
Committed r56199: <http://trac.webkit.org/changeset/56199>