Bug 36288 - Need a layout test for finding yensign from documents with Japanese encodings
Summary: Need a layout test for finding yensign from documents with Japanese encodings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-18 01:07 PDT by Shinichiro Hamaji
Modified: 2010-03-19 08:03 PDT (History)
2 users (show)

See Also:

Patch v1 (4.84 KB, patch)
2010-03-18 01:11 PDT, Shinichiro Hamaji
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-03-18 01:07:40 PDT
We need a layout test to ensure we can find a backslash in Japanese encodings by searching a yen sign. This test will help Bug 24906 because we can avoid regressions of searching.
Comment 1 Shinichiro Hamaji 2010-03-18 01:11:10 PDT
Created attachment 51014 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-03-18 01:18:28 PDT
On Windows, Qt, and Gtk, this test fails. I didn't examine the reason yet. On Windows and Qt, finding a backslash in non-text-control is failing. On Gtk, finding a backslash in both text-control and non-text-control is failing.

Anyway, as I wrote in Bug 24906, I think we want to allow users to find both backslashes and yen signs by searching either a backslash or a yen sign. If people agrees with me, I'll change the searching code in some future day and these skip lists will be gone.
Comment 3 Darin Adler 2010-03-18 17:48:56 PDT
Comment on attachment 51014 [details]
Patch v1

In cases like this, I think that landing expected results that expect failure is better than adding tests to the Skipped lists. We can remove the expected failures when we fix the bug.

r=me as-is, but I'd prefer to run tests rather than skipping them
Comment 4 Shinichiro Hamaji 2010-03-18 20:47:15 PDT
I see. I'll add failing expectations when I land. Thanks for your review!
Comment 5 Shinichiro Hamaji 2010-03-19 08:03:30 PDT
Committed r56238: <http://trac.webkit.org/changeset/56238>