Bug 36279 – CSS3 :nth-child selector and valid whitespace test fails

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

Created attachment 51005 [details]
Testcase

This test fails:
http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/ValidWhitespace.htm

[Yael]

Created attachment 77859 [details]
Patch

Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

[Darin Adler]

Comment on attachment 77859 [details]
Patch

Changing the tokenizer but not updating CSSSelector::RareData::parseNth is not going to work correctly. It seems the test case here was insufficient to detect that. Please work on a patch that changes both the tokenizer and the parser to allow spaces!

[Yael]

(In reply to comment #2)
> (From update of attachment 77859 [details])
> Changing the tokenizer but not updating CSSSelector::RareData::parseNth is not going to work correctly. It seems the test case here was insufficient to detect that. Please work on a patch that changes both the tokenizer and the parser to allow spaces!

Thank you for your review, Darin.
I was under the impression that CSSSelector::RareData::parseNth already allows the spaces, but I could be wrong.

CSSSelector::RareData::parseNth uses String::find() to find the sign + or -, and does not assume that the sign follows immediately after n.

CSSSelector::RareData::parseNth uses String::toInt() to find the value of b, and that already knows how to skip leading spaces.

Do you have a specific case in mind that could fail ?

[Simon Fraser (smfr)]

RareData::parseNth() looks like it deals with whitespace OK. Darin, are you OK with the patch?

[Darin Adler]

(In reply to comment #3)
> I was under the impression that CSSSelector::RareData::parseNth already allows the spaces

You are right. Sorry, I was wrong!

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77859 [details]:

http/tests/appcache/progress-counter.html bug 51913 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 77859 [details]
Patch

Clearing flags on attachment: 77859

Committed r75039: <http://trac.webkit.org/changeset/75039>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/75039 might have broken Leopard Intel Debug (Tests)