This test fails: http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/notSelectorSequence.htm
Created attachment 52287 [details] Fix bug: :not() must not accept simple selector sequence.
Comment on attachment 52287 [details] Fix bug: :not() must not accept simple selector sequence. Please rename numCondition to numConditions. r=me
Committed r56959: <http://trac.webkit.org/changeset/56959>
http://trac.webkit.org/changeset/56959 might have broken Leopard Intel Release (Tests)
Rolled r56959 our.
(In reply to comment #5) > Rolled r56959 our. our -> out :-)
Which tests failed?
(In reply to comment #7) > Which tests failed? http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/12483/steps/layout-test/logs/stdio http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/12307/steps/layout-test/logs/stdio svg/W3C-SVG-1.1/coords-units-01-b.svg -> failed svg/W3C-SVG-1.1/pservers-pattern-01-b.svg -> failed svg/batik/paints/patternPreserveAspectRatioA.svg -> failed svg/batik/paints/patternRegionA.svg -> failed svg/batik/paints/patternRegions.svg -> failed svg/custom/deep-dynamic-updates.svg -> failed svg/custom/pattern-cycle-detection.svg -> failed svg/custom/pattern-deep-referencing.svg -> failed svg/custom/pattern-with-transformation.svg -> failed svg/custom/pattern-y-offset.svg -> failed svg/custom/use-on-symbol-inside-pattern.svg -> failed
Created attachment 52396 [details] Second trial. Now all tests, including svg ones, passes.
Sorry for the test breakage. CSSSelector::hasTag() behaves differently from my expectation if namespace is set. Fixed bool CSSSelector::isSimple() const accordingly. The second patch passes all tests. Can you take another look?
Committed r57161: <http://trac.webkit.org/changeset/57161>
Committed r57295: <http://trac.webkit.org/changeset/57295>
r57161 contains the main part of the change. r57295 contains the test accidentally dropped from r57161. Sorry for the mistake.
Committed r57298: <http://trac.webkit.org/changeset/57298>
Sorry again. (Now I know why the files were dropped.) r57161 contains the main part of the change. r57295 almost empty r57298 contains the test accidentally dropped from r57161.