Bug 36272 - CSS3 :nth-child selector with implied step test fails
Summary: CSS3 :nth-child selector with implied step test fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL: http://samples.msdn.microsoft.com/iet...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-17 20:16 PDT by Simon Fraser (smfr)
Modified: 2010-03-23 13:53 PDT (History)
0 users

See Also:

Attachments
Testcase (1.80 KB, text/html)
2010-03-17 20:16 PDT, Simon Fraser (smfr) 		no flags Details
Patch (4.94 KB, patch)
2010-03-23 13:45 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-03-17 20:16:30 PDT 
Created attachment 50998 [details]
Testcase

The test here fails:
http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/impliedValue.htm
Comment 1 Dave Hyatt 2010-03-23 13:45:04 PDT 
Created attachment 51451 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-03-23 13:48:01 PDT 
Comment on attachment 51451 [details]
Patch

Where is LayoutTests/ChangeLog?
r=me.
Comment 3 Darin Adler 2010-03-23 13:49:36 PDT 
Comment on attachment 51451 [details]
Patch

> -        $$->setArgument(String::number($4));
> +        $$->setArgument(String::number($4*$5));

Should be $4 * $5 with spaces around the multiplication operator.

I'd like to see test cases covering the edge cases, for example the maximum negative number.

r=me
Comment 4 Dave Hyatt 2010-03-23 13:53:07 PDT 
Fixed in r56414.