Bug 36255 - Remove Geolocation.lastPosition, no longer in the spec.
: Remove Geolocation.lastPosition, no longer in the spec.
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-17 17:47 PST by
Modified: 2010-04-21 13:16 PST (History)


Attachments
Patch (4.75 KB, patch)
2010-03-17 17:50 PST, Darin Adler
kenneth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-17 17:47:36 PST
Remove Geolocation.lastPosition, no longer in the spec.
------- Comment #1 From 2010-03-17 17:50:37 PST -------
Created an attachment (id=50983) [details]
Patch
------- Comment #2 From 2010-03-17 17:57:43 PST -------
(From update of attachment 50983 [details])
LGTM.
------- Comment #3 From 2010-03-18 13:33:55 PST -------
Not sure why the EWS is not running on this patch. Maybe it only runs on review? patches?
------- Comment #4 From 2010-03-18 13:42:33 PST -------
http://trac.webkit.org/changeset/56188
------- Comment #5 From 2010-03-18 16:37:32 PST -------
The suspend() and resume() methods are used by Android (and soon Chromium). Is it possible to add them back?

See Bug 36255 for how they're used.
------- Comment #6 From 2010-03-18 17:09:22 PST -------
GeolocationServiceBridgeChromium.cpp says:

    getWebViewClient()->getGeolocationService()->suspend(m_bridgeId)

Bug 36255 is this bug.

If you do need those functions on certain platforms, then I suppose it's OK to bring them back. It's not good to have requirements that can't be seen by someone just be looking at the WebKit source tree. Android is not in a good state for maintenance until the WebKit code is checked in to the open source project.
------- Comment #7 From 2010-03-18 18:38:22 PST -------
> Bug 36255 is this bug.
Sorry, I meant Bug 34082

> It's not good to have requirements that can't be seen by
> someone just be looking at the WebKit source tree. Android is not in a good
> state for maintenance until the WebKit code is checked in to the open source
> project.
Agreed. We're working hard right now to upstream all of Android's WebKit code.
------- Comment #8 From 2010-04-21 13:16:05 PST -------
> If you do need those functions on certain platforms, then I suppose it's OK to
> bring them back.
OK, I've opened Bug 37942 to track this.