Bug 36254 - Add more infrastructure for sheriff-bot, including making what-broke more awesome
Summary: Add more infrastructure for sheriff-bot, including making what-broke more awe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-17 17:46 PDT by Eric Seidel (no email)
Modified: 2010-03-17 18:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (37.46 KB, patch)
2010-03-17 17:48 PDT, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-03-17 17:46:01 PDT 
Add more infrastructure for sheriff-bot, including making what-broke more awesome
Comment 1 Eric Seidel (no email) 2010-03-17 17:48:05 PDT 
Created attachment 50981 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-17 17:51:13 PDT 
CCing dbates, as I think he is the culprit behind the SCM.commit_with_message breakage of the scm unittests. :)
Comment 3 Adam Barth 2010-03-17 18:04:40 PDT 
Comment on attachment 50981 [details]
Patch

This is like 27 different patch, but ok.  Also, all the code you're adding to what-broke needs to be factored out into separate concepts so it can be re-used by other parts of the system.

Thanks for fixing all the SCM unit tests.
Comment 4 Eric Seidel (no email) 2010-03-17 18:09:58 PDT 
Committed r56137: <http://trac.webkit.org/changeset/56137>