Bug 36253 - First cut at SheriffBot
Summary: First cut at SheriffBot
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-17 17:19 PDT by Adam Barth
Modified: 2010-03-18 12:49 PDT (History)
2 users (show)

See Also:

Patch (17.94 KB, patch)
2010-03-17 17:24 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (17.89 KB, patch)
2010-03-17 17:49 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-17 17:19:39 PDT
First cut at SheriffBot
Comment 1 Adam Barth 2010-03-17 17:24:14 PDT
Created attachment 50978 [details]
Comment 2 Eric Seidel (no email) 2010-03-17 17:43:02 PDT
Comment on attachment 50978 [details]

I think IRC connection should be explicit.  It's "dangerous".  It should just return None until someone has explicitly connected.

Or you coudl have an ensure_irc_connected() method, which makes it clear that it does work.  "irc()" could leave me in some sort of false impression that it doesn't do any work, or certainly doesn't connect me to anything.

I think if we have some explicit connect method it should take a username/host/channel, as whoever is calling it will have that information.

I worry that the name "finalize" is overloaded.  Maybe we should have some custom name.  I think you mentioned "command_completed()" in person.   The default implementation could pass.
Comment 3 Adam Barth 2010-03-17 17:49:39 PDT
Created attachment 50982 [details]
Comment 4 Eric Seidel (no email) 2010-03-18 01:09:19 PDT
Comment on attachment 50982 [details]

Comment 5 WebKit Commit Bot 2010-03-18 12:49:42 PDT
Comment on attachment 50982 [details]

Clearing flags on attachment: 50982

Committed r56181: <http://trac.webkit.org/changeset/56181>
Comment 6 WebKit Commit Bot 2010-03-18 12:49:46 PDT
All reviewed patches have been landed.  Closing bug.