RESOLVED FIXED 36253
First cut at SheriffBot 
https://bugs.webkit.org/show_bug.cgi?id=36253
Summary First cut at SheriffBot
Adam Barth
Reported 2010-03-17 17:19:39 PDT
First cut at SheriffBot
Attachments
Patch (17.94 KB, patch)
2010-03-17 17:24 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (17.89 KB, patch)
2010-03-17 17:49 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-03-17 17:24:14 PDT
Created attachment 50978 [details] Patch
Eric Seidel (no email)
Comment 2 2010-03-17 17:43:02 PDT
Comment on attachment 50978 [details] Patch I think IRC connection should be explicit. It's "dangerous". It should just return None until someone has explicitly connected. Or you coudl have an ensure_irc_connected() method, which makes it clear that it does work. "irc()" could leave me in some sort of false impression that it doesn't do any work, or certainly doesn't connect me to anything. I think if we have some explicit connect method it should take a username/host/channel, as whoever is calling it will have that information. I worry that the name "finalize" is overloaded. Maybe we should have some custom name. I think you mentioned "command_completed()" in person. The default implementation could pass.
Adam Barth
Comment 3 2010-03-17 17:49:39 PDT
Created attachment 50982 [details] Patch
Eric Seidel (no email)
Comment 4 2010-03-18 01:09:19 PDT
Comment on attachment 50982 [details] Patch OK.
WebKit Commit Bot
Comment 5 2010-03-18 12:49:42 PDT
Comment on attachment 50982 [details] Patch Clearing flags on attachment: 50982 Committed r56181: <http://trac.webkit.org/changeset/56181>
WebKit Commit Bot
Comment 6 2010-03-18 12:49:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.