Bug 36247 - Dragging a PDF image triggers assertion in DragController::startDrag()
Summary: Dragging a PDF image triggers assertion in DragController::startDrag()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-17 15:58 PDT by Jian Li
Modified: 2010-03-18 18:06 PDT (History)
1 user (show)

See Also:


Attachments
Proposed Patch (3.58 KB, patch)
2010-03-17 16:00 PDT, Jian Li
dimich: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-03-17 15:58:37 PDT
DragController.cpp:675: ASSERT(!image->filenameExtension().isEmpty());

We need to do the similar thing as in the fix for bug 32511: make PDFDocumentImage::filenameExtension() return a valid string.
Comment 1 Jian Li 2010-03-17 16:00:33 PDT
Created attachment 50967 [details]
Proposed Patch
Comment 2 Dmitry Titov 2010-03-18 17:54:38 PDT
Comment on attachment 50967 [details]
Proposed Patch

Looks good.
Comment 3 Jian Li 2010-03-18 18:06:41 PDT
Committed as http://trac.webkit.org/changeset/56205.