Bug 36230 - Image_diff.py for layout test is broken if no diff file specified
: Image_diff.py for layout test is broken if no diff file specified
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-17 11:23 PST by
Modified: 2010-03-17 15:21 PST (History)


Attachments
Proposed patch (1.52 KB, patch)
2010-03-17 11:36 PST, Victor Wang
dglazkov: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-17 11:23:44 PST
In webkitpy/port/base.py, the syntax of command image_diff is wrong if no diff_filename specified. This breaks rebaseline tool.
------- Comment #1 From 2010-03-17 11:36:23 PST -------
Created an attachment (id=50928) [details]
Proposed patch
------- Comment #2 From 2010-03-17 11:39:28 PST -------
(From update of attachment 50928 [details])
yay!
------- Comment #3 From 2010-03-17 11:45:39 PST -------
Committed r56123: <http://trac.webkit.org/changeset/56123>
------- Comment #4 From 2010-03-17 14:18:00 PST -------
(From update of attachment 50928 [details])
I wonder if it would be better to split this into a different routine called compare_images() that compared them but didn't produce an actual diff, just like we have compare_text() and diff_text().
------- Comment #5 From 2010-03-17 15:21:21 PST -------
Sounds fine to me.

(In reply to comment #4)
> (From update of attachment 50928 [details] [details])
> I wonder if it would be better to split this into a different routine called
> compare_images() that compared them but didn't produce an actual diff, just
> like we have compare_text() and diff_text().