Bug 36230 - Image_diff.py for layout test is broken if no diff file specified
: Image_diff.py for layout test is broken if no diff file specified
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To: Victor Wang
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-17 11:23 PDT by Victor Wang
Modified: 2010-03-17 15:21 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (1.52 KB, patch)
2010-03-17 11:36 PDT, Victor Wang
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-03-17 11:23:44 PDT
In webkitpy/port/base.py, the syntax of command image_diff is wrong if no diff_filename specified. This breaks rebaseline tool.
Comment 1 Victor Wang 2010-03-17 11:36:23 PDT
Created attachment 50928 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-03-17 11:39:28 PDT
Comment on attachment 50928 [details]
Proposed patch

yay!
Comment 3 Victor Wang 2010-03-17 11:45:39 PDT
Committed r56123: <http://trac.webkit.org/changeset/56123>
Comment 4 Dirk Pranke 2010-03-17 14:18:00 PDT
Comment on attachment 50928 [details]
Proposed patch

I wonder if it would be better to split this into a different routine called compare_images() that compared them but didn't produce an actual diff, just like we have compare_text() and diff_text().
Comment 5 Victor Wang 2010-03-17 15:21:21 PDT
Sounds fine to me.

(In reply to comment #4)
> (From update of attachment 50928 [details])
> I wonder if it would be better to split this into a different routine called
> compare_images() that compared them but didn't produce an actual diff, just
> like we have compare_text() and diff_text().