Bug 36214 - WebCore/bridge uses bzero, which is not available on Android without extra includes
Summary: WebCore/bridge uses bzero, which is not available on Android without extra in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-17 04:36 PDT by Steve Block
Modified: 2010-03-17 05:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2010-03-17 04:40 PDT, Steve Block 		jorlow: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-03-17 04:36:32 PDT 
WebCore/bridge uses bzero. Android's stdlib.h will soon be modified to not include strings.h, in order to reduce pollution of the standard C namespace. Without strings.h being included from stdlib.h, use of bzero would require additional local includes on Android.

Rather than add includes, we should replace calls to bzero with memset, as this is what is used throughout WebCore common code.
Comment 1 Steve Block 2010-03-17 04:40:46 PDT 
Created attachment 50893 [details]
Patch
Comment 2 Jeremy Orlow 2010-03-17 04:50:31 PDT 
Comment on attachment 50893 [details]
Patch

Looks like a no-op and consistency is good.  r=me
Comment 3 Steve Block 2010-03-17 05:12:22 PDT 
Committed r56105: <http://trac.webkit.org/changeset/56105>