Bug 36204 - [Chromium] Size the WebVector of forms after determining how many forms are valid and will be returned
Summary: [Chromium] Size the WebVector of forms after determining how many forms are v...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-16 17:28 PDT by James Hawkins
Modified: 2010-03-16 18:54 PDT (History)
3 users (show)

See Also:

Patch (1.31 KB, patch)
2010-03-16 18:06 PDT, James Hawkins
no flags Details | Formatted Diff | Diff
Patch (1.32 KB, patch)
2010-03-16 18:18 PDT, James Hawkins
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2010-03-16 17:28:31 PDT
Patch will follow.
Comment 1 James Hawkins 2010-03-16 18:06:07 PDT
Created attachment 50861 [details]
Comment 2 David Levin 2010-03-16 18:16:51 PDT
Comment on attachment 50861 [details]

Pls fix the indentation to be 4 spaces on checkin.
Comment 3 James Hawkins 2010-03-16 18:18:05 PDT
Created attachment 50863 [details]
Comment 4 Dimitri Glazkov (Google) 2010-03-16 18:18:33 PDT
Comment on attachment 50861 [details]

I am surprised style-elf didn't see it, but indents are 2, not 4.

And we really need a test with this. Something simple like PASS or CRASH would do.
Comment 5 Dimitri Glazkov (Google) 2010-03-16 18:19:08 PDT
Still would like a layout test to keep this from regressing.
Comment 6 David Levin 2010-03-16 18:26:25 PDT
As discussed, please add info to the ChangeLog about why a test isn't possible.
Comment 7 James Hawkins 2010-03-16 18:54:10 PDT
Committed r56098: <http://trac.webkit.org/changeset/56098>