Bug 36203 - Add tests for "load shared worker in iframe"
Summary: Add tests for "load shared worker in iframe"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-16 17:12 PDT by Andrew Wilson
Modified: 2010-03-17 17:37 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2010-03-16 17:19 PDT, Andrew Wilson
no flags Details | Formatted Diff | Diff
Patch (3.13 KB, patch)
2010-03-16 17:37 PDT, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2010-03-16 17:12:58 PDT
We found a bug in downstream Chromium related to launching shared workers simultaneously in a top-level document and in an iframe.

Turns out that we don't explicitly test this case in any of the WebKit layout tests, so we should add a test.
Comment 1 Andrew Wilson 2010-03-16 17:19:45 PDT
Created attachment 50854 [details]
Patch
Comment 2 David Levin 2010-03-16 17:34:29 PDT
Comment on attachment 50854 [details]
Patch

This looks good. Thanks!

r- for mild issue having two files wit the same name "shared-worker-iframe.html" but having different purposes.
Comment 3 Andrew Wilson 2010-03-16 17:37:18 PDT
Created attachment 50857 [details]
Patch
Comment 4 WebKit Commit Bot 2010-03-17 17:37:12 PDT
Comment on attachment 50857 [details]
Patch

Clearing flags on attachment: 50857

Committed r56136: <http://trac.webkit.org/changeset/56136>
Comment 5 WebKit Commit Bot 2010-03-17 17:37:16 PDT
All reviewed patches have been landed.  Closing bug.